improve wbs-qs:rebuild signature #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
approved these changes
Oct 15, 2025
tarrow
reviewed
Oct 15, 2025
| use Traits\PageFetcher; | ||
|
|
||
| protected $signature = 'wbs-qs:rebuild {--domain=*} {--chunkSize=50} {--queueName=manual-intervention} {--sparqlUrlFormat=http://queryservice.default.svc.cluster.local:9999/bigdata/namespace/%s/sparql}'; | ||
| protected $signature = 'wbs-qs:rebuild {--domain=*} {--chunkSize=50} {--queueName=default} {--sparqlUrlFormat=http://queryservice.default.svc.cluster.local:9999/bigdata/namespace/%s/sparql}'; |
There was a problem hiding this comment.
praise: yeah, excellent spot and good prediction from 2 years ago that this would be a thing some fool (aka. Tom) would trip up on!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found out in https://phabricator.wikimedia.org/T406426#11263064
the RebuildQueryserviceData Command class had a not very useful signature, since we do not have any queue configured that is named 'manual-intervention'. As this blocked us quite I bit I propose to change the default value just to 'default'; this way we still can use a different queue if we want to, but it also works without specifying a named one. I guess another improvement could be to check the named queue actually exists, because currently it won't hint anything like this.
also see #710 (review)